Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-08 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122691 --- Fix it, then Ship it! Looks great! One more little bit of

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122465 --- Patch looks great! Reviews applied: [44408] Passed command:

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Yong Tang
> On March 7, 2016, 7:39 p.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, lines 295-299 > > > > > > Nit: An arrangement like this is preferable: > > ``` > > FrameworkInfo frameworkInfo =

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 7, 2016, 8:52 p.m.) Review request for mesos and Joseph Wu.

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-07 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122346 --- Fix it, then Ship it! LGTM. You should probably ask Adam to

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122192 --- Patch looks great! Reviews applied: [44408] Passed command:

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
> On March 5, 2016, 2:31 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, lines 283-284 > > > > > > One more small refinement: > > > > Now that the master does not use this variable, you

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 5, 2016, 4:17 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Guangya Liu
> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). > > Guangya Liu wrote: > @Jopseph,

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122173 --- BTW, thanks for doing this :)

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Joseph Wu
> On March 4, 2016, 5:25 p.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). > > Guangya Liu wrote: > @Jopseph,

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- (Updated March 5, 2016, 2:24 a.m.) Review request for mesos and Joseph Wu.

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Guangya Liu
> On 三月 5, 2016, 1:25 a.m., Joseph Wu wrote: > > src/tests/persistent_volume_tests.cpp, line 89 > > > > > > This entire helper is not needed anymore (due to implicit roles). @Jopseph, why also remove acls here? The

Re: Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/#review122163 --- src/tests/persistent_volume_tests.cpp (line 89)

Review Request 44408: Remove setting up of ACLs (unneeded) in PersistentVolumeTests.

2016-03-04 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44408/ --- Review request for mesos and Joseph Wu. Bugs: MESOS-4868