Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124394 --- Ship it! Ship It! - Joerg Schad On March 17, 2016, 7:42

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review124388 --- Ship it! Ship It! - Adam B On March 17, 2016, 12:42 p.m.,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 14, 2016, 2:33 p.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review123398 --- I think you need to remove your `constants.cpp` after Neil's

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 13, 2016, 4:26 p.m., Joerg Schad wrote: > > src/master/constants.hpp, line 136 > > > > > > Should we make it "master HTTP authentication realm."? Good idea; done! - Greg

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 14, 2016, 4:18 a.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review123316 --- Fix it, then Ship it! src/master/constants.hpp (line 136)

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review123306 --- Ship it! Ship It! - Adam B On March 11, 2016, 2:04 a.m.,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 10, 2016, 4:02 a.m., Alexander Rojas wrote: > > I just did a grep and I found this: > > > > ```sh > > $ ag --cpp --ignore="build/.*" '\"mesos\"' . > > # ... > > src/authentication/http/basic_authenticator_factory.cpp > > 66: Authenticator* authenticator = new

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 10, 2016, 9:40 p.m.) Review request for mesos, Adam B,

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 9, 2016, 8:02 p.m., Alexander Rojas wrote: > > I just did a grep and I found this: > > > > ```sh > > $ ag --cpp --ignore="build/.*" '\"mesos\"' . > > # ... > > src/authentication/http/basic_authenticator_factory.cpp > > 66: Authenticator* authenticator = new

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122874 --- I just did a grep and I found this: ```sh $ ag --cpp

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- (Updated March 9, 2016, 8:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

> On March 8, 2016, 11:37 p.m., Adam B wrote: > > src/master/constants.cpp, lines 52-53 > > > > > > Would the same hold true for any machine that runs both a master and an > > agent process? > > Or is it only

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122669 --- Patch looks great! Reviews applied: [44515, 44523] Passed

Re: Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/#review122630 --- src/master/constants.cpp (lines 52 - 53)

Review Request 44523: Changed the master's default HTTP authentication realm.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44523/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs: