Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- Review request for mesos, Adam B, Alexander Rojas, and Till Toenshoff. Bugs: ME

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review122901 --- Can you add some tests for these endpoints that show that hitting

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 10, 2016, 7:45 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

> On March 10, 2016, 8:57 a.m., Adam B wrote: > > Can you add some tests for these endpoints that show that hitting them with > > a bad credential will fail with status Unauthorized? See > > `TeardownTest.TeardownEndpointBadCredentials` or > > `PersistentVolumeEndpointsTest.BadCredentials`. G

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 9:52 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123137 --- Ship it! Ship It! - Alexander Rojas On March 11, 2016, 10:52

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123139 --- Fix it, then Ship it! src/tests/containerizer/docker_container

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

> On March 11, 2016, 2:29 p.m., Joerg Schad wrote: > > src/tests/slave_tests.cpp, line 1435 > > > > > > Should we add a comment that authn is required by default? required -> enabled by default in testcases. - Jo

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review123142 --- src/tests/health_check_tests.cpp (line 642)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 4:06 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:54 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 11, 2016, 6:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 14, 2016, 4:18 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124194 --- src/slave/http.cpp (line 54)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 18, 2016, 7:16 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 18, 2016, 7:12 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 17, 2016, 10:56 p.m.) Review request for mesos, Adam B, Alexande

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124161 --- Fix it, then Ship it! Minor suggestions src/tests/slave_tests

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 17, 2016, 7:43 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

> On March 18, 2016, 3:47 p.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 677 > > > > > > Where is this coming from? I would expect this in slave/constants.hpp > > similar as for the master > > > >

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124397 --- src/tests/slave_tests.cpp (line 1504)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/#review124207 --- src/slave/slave.cpp (line 677)

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 20, 2016, 5:32 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 20, 2016, 7:10 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:23 a.m.) Review request for mesos, Adam B, Alexande

Re: Review Request 44553: Added authentication to agent HTTP endpoints.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44553/ --- (Updated March 23, 2016, 11:39 a.m.) Review request for mesos, Adam B, Alexande