Review Request 44580: Made changes to the executor library around managing connections.

2016-03-09 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-4858 https://issues.ap

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/#review122785 --- Patch looks great! Reviews applied: [44578, 44579, 44580] Passed

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/#review123223 --- Fix it, then Ship it! src/executor/executor.cpp (line 424)

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44580/ --- (Updated March 11, 2016, 11:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 44580: Made changes to the executor library around managing connections.

2016-03-11 Thread Anand Mazumdar
> On March 11, 2016, 10:44 p.m., Vinod Kone wrote: > > src/executor/executor.cpp, line 462 > > > > > > This if statement sounds like all combinations of "checkpoint", > > "connecting" and "recoveryTimeout" are possi