Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4911 https://issues.ap

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-11 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-14 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- (Updated March 14, 2016, 5:48 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-15 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- (Updated March 15, 2016, 2:15 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review123713 --- Looks great! Main thing is documenting why we don't assume the env

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-19 Thread Alexander Rukletsov
> On March 15, 2016, 6:39 p.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 113 > > > > > > If you'd like to add the `private` qualifier, why isn't `kill` left as > > protected? I do not know what is our general

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-19 Thread Ben Mahler
> On March 18, 2016, 8:36 p.m., Ben Mahler wrote: > > s/executor library/executor driver/ - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review124276 ---

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/ --- (Updated March 17, 2016, 11:30 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-19 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44654/#review124276 --- Ship it! src/exec/exec.cpp (lines 710 - 711)

Re: Review Request 44654: Fixed hard-coded executor shutdown grace period in executor library.

2016-03-20 Thread Ben Mahler
> On March 15, 2016, 6:39 p.m., Ben Mahler wrote: > > src/exec/exec.cpp, line 113 > > > > > > If you'd like to add the `private` qualifier, why isn't `kill` left as > > protected? > > Alexander Rukletsov wrote: >