Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 4, 2016, 4:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread Guangya Liu
> On 四月 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4694 > > > > > > I know that those code are copied from > > `MesosContainerizerProcess::recover`, but it is better update the comments >

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/slave.cpp, line 4694 > > > > > > I know that those code are copied from > > `MesosContainerizerProcess::recover`, but it is better update the comments

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
> On April 3, 2016, 2:25 p.m., Guangya Liu wrote: > > It is always suggested to use past tone for the summary and ditto for the > > patch chain. Got it. I would update in next round. - haosdent --- This is an automatically generated e-

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
> On April 3, 2016, 2:08 p.m., Guangya Liu wrote: > > src/slave/containerizer/containerizer.hpp, line 29 > > > > > > what is the use of this include for this patch? Thanks for your view. `ContainerState` is defined i

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/#review126729 --- It is always suggested to use past tone for the summary and ditto

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 3, 2016, 2:09 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/#review126726 --- src/slave/containerizer/containerizer.hpp (line 29)

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 16, 2016, 11:21 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 44798: Update `Slave::_recoverContainerizer` to use `ContainerState`.

2016-03-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44798/ --- (Updated March 15, 2016, 2:02 a.m.) Review request for mesos and Till Toenshoff