Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-04 Thread haosdent huang
> On April 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 825-826 > > > > > > I think that here should be `||` but not `&&` > > haosdent huang wrote: > Actually these code e

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 4, 2016, 4:48 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread Guangya Liu
> On 四月 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 825-826 > > > > > > I think that here should be `||` but not `&&` > > haosdent huang wrote: > Actually these code exis

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread haosdent huang
> On April 3, 2016, 2:22 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 794-797 > > > > > > const ExecutorInfo& executorInfo = recoverable.executor_info(); > > const ContainerID& container

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/#review126728 --- src/slave/containerizer/docker.cpp (lines 785 - 788)

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 3, 2016, 2:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-04-03 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated April 3, 2016, 1:06 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated March 16, 2016, 11:26 a.m.) Review request for mesos and Till Toenshof

Re: Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-03-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- (Updated March 16, 2016, 5:56 p.m.) Review request for mesos and Till Toenshoff

Review Request 44823: Remove `SlaveState` in `DockerContainerizer` during recover.

2016-03-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44823/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --