Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review124403 --- Patch looks great! Reviews applied: [44836] Passed command: expo

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-18 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review124364 --- src/examples/long_lived_framework.cpp (line 88)

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 16, 2016, 2:27 a.m.) Review request for mesos and haosdent huang

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 16, 2016, 2:21 a.m.) Review request for mesos and haosdent huang

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review123653 --- Patch looks great! Reviews applied: [44836] Passed command: expo

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread haosdent huang
> On March 15, 2016, 7:04 a.m., haosdent huang wrote: > > > > haosdent huang wrote: > I also notice the submitter `guojian...@cn.ibm.com` is different with > signer `Zhou Xing `. I suggest don't do it like this. > > Jay Guo wrote: > We are following pair programming pattern and use git

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
> On March 15, 2016, 7:04 a.m., haosdent huang wrote: > > > > haosdent huang wrote: > I also notice the submitter `guojian...@cn.ibm.com` is different with > signer `Zhou Xing `. I suggest don't do it like this. We are following pair programming pattern and use git-duet. Will do clean com

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
> On March 15, 2016, 7:01 a.m., haosdent huang wrote: > > Thank you for your patch. Could you update the `Bugs` field to > > `MESOS-4930`? By the way, I think you need find a shepherd for this ticket. > > Could you follow this guide > > https://github.com/apache/mesos/blob/master/docs/submitti

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- (Updated March 15, 2016, 7:49 a.m.) Review request for mesos and haosdent huang

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread haosdent huang
> On March 15, 2016, 7:04 a.m., haosdent huang wrote: > > I also notice the submitter `guojian...@cn.ibm.com` is different with signer `Zhou Xing `. I suggest don't do it like this. - haosdent --- This is an automatically generated e-m

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review123608 --- src/examples/long_lived_framework.cpp (line 98)

Re: Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-15 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/#review123607 --- Thank you for your patch. Could you update the `Bugs` field to `ME

Review Request 44836: Update TaskId in long_lived_framework to use fixed length taskid.

2016-03-14 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44836/ --- Review request for mesos and haosdent huang. Repository: mesos Description --