Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review125393 --- Fix it, then Ship it! Looks great. I'll fix up these last bits

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- (Updated March 24, 2016, 2:22 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- (Updated March 24, 2016, 1:45 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-24 Thread Jan Schlicht
> On March 17, 2016, 6:21 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 227 > > > > > > We now mention deprecated twice here. > > The 'Note that' also seems to be out of sync with the configuration.md.

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124550 --- Patch looks great! Reviews applied: [44846] Passed command: expo

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124528 --- I know we leave deprecated flags in and document them as deprecate

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review124051 --- Fix it, then Ship it! Could you please check that all the markd

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Greg Mann
> On March 15, 2016, 6:53 p.m., Greg Mann wrote: > > FYI, this review: https://reviews.apache.org/r/44515/ adds command-line > > credentials to the agent with the `--http_credentials` flag. Depending on > > which one of these lands first, the other one should be updated to remain > > consisten

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123720 --- FYI, this review: https://reviews.apache.org/r/44515/ adds command

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- (Updated March 15, 2016, 3:01 p.m.) Review request for mesos, Adam B and Joerg

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Joerg Schad
> On March 15, 2016, 12:40 p.m., Guangya Liu wrote: > > The configuration.md > > https://github.com/apache/mesos/blob/master/docs/configuration.md should > > also be updated. > > Joerg Schad wrote: > see my 2nd comment above :-). > > Guangya Liu wrote: > Sorry, I missed that, so you p

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Guangya Liu
> On 三月 15, 2016, 12:40 p.m., Guangya Liu wrote: > > The configuration.md > > https://github.com/apache/mesos/blob/master/docs/configuration.md should > > also be updated. > > Joerg Schad wrote: > see my 2nd comment above :-). Sorry, I missed that, so you plan fix it in this patch or foll

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Joerg Schad
> On March 15, 2016, 12:40 p.m., Guangya Liu wrote: > > The configuration.md > > https://github.com/apache/mesos/blob/master/docs/configuration.md should > > also be updated. see my 2nd comment above :-). - Joerg --- This is an automa

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123646 --- The configuration.md https://github.com/apache/mesos/blob/master/

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123642 --- src/master/flags.cpp (line 224)

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123641 --- And as we changed the flags we should most likely also update conf

Re: Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/#review123639 --- Can you also add this upgrades.md? - Joerg Schad On March 15, 2

Review Request 44846: Deprecated the plain text credential format.

2016-03-15 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44846/ --- Review request for mesos, Adam B and Joerg Schad. Bugs: MESOS-2281 https://