Re: Review Request 45121: Implemented deletion for persistent volumes.

> On March 26, 2016, 12:37 a.m., Jie Yu wrote: > > src/slave/slave.cpp, line 2375 > > > > > > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the > > deletion fails. Given the TODO above, we

Re: Review Request 45121: Implemented deletion for persistent volumes.

> On March 26, 2016, 12:37 a.m., Jie Yu wrote: > > src/slave/slave.cpp, line 2375 > > > > > > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the > > deletion fails. Given the TODO above, we

Re: Review Request 45121: Implemented deletion for persistent volumes.

> On March 26, 2016, 12:37 a.m., Jie Yu wrote: > > src/slave/slave.cpp, line 2375 > > > > > > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the > > deletion fails. Given the TODO above, we

Re: Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/ --- (Updated March 27, 2016, 6:08 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45121: Implemented deletion for persistent volumes.

> On March 26, 2016, 12:37 a.m., Jie Yu wrote: > > src/slave/slave.cpp, line 2375 > > > > > > I would suggest we don't use CHECK here. We can just LOG(ERROR) if the > > deletion fails. Given the TODO above, we

Re: Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/#review125492 --- Fix it, then Ship it! src/slave/slave.cpp (line 2333)

Review Request 45121: Implemented deletion for persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45121/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Repository: mesos