Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125710 --- Ship it! Ship It! - Jie Yu On March 28, 2016, 6:20 p.m., Nei

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 28, 2016, 6:20 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Jie Yu
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Jie Yu
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 28, 2016, 4:07 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 243 > > > > > > Can we create a new test, instead of piggyback on this test? In the new > > test, you can test the 'crea

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Jie Yu
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? > > Neil Conway wrote: > I wanted to check that if fil

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-28 Thread Jie Yu
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 243 > > > > > > Can we create a new test, instead of piggyback on this test? In the new > > test, you can test the 'crea

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-27 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 243 > > > > > > Can we create a new test, instead of piggyback on this test? In the new > > test, you can test the 'crea

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-27 Thread Neil Conway
> On March 26, 2016, 12:53 a.m., Jie Yu wrote: > > src/tests/persistent_volume_tests.cpp, line 810 > > > > > > What the purpose of adding another file here? I wanted to check that if files are directly written into

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-27 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 27, 2016, 10:05 p.m.) Review request for mesos, Jie Yu and Joris

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/#review125499 --- src/tests/persistent_volume_tests.cpp (line 243)

Re: Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- (Updated March 21, 2016, 6:44 p.m.) Review request for mesos, Jie Yu and Joris

Review Request 45122: Updated tests for deletion of persistent volumes.

2016-03-21 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45122/ --- Review request for mesos, Jie Yu and Joris Van Remoortere. Repository: mesos