Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Jörg Schad
Only '../configure --with-network-isolator' which unfortunately wasn't the case on neither of the system.. Sorry for the inconvenience, fix is just being tested. On Mon, Mar 28, 2016 at 7:15 PM, Cong Wang wrote: > I am wondering how does it pass your test since you did `make check` > on both Lin

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joerg Schad
> On March 28, 2016, 5:06 p.m., Cong Wang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 311 > > > > > > This one breaks build even after all of your 7 patches are committed, > > because port_ma

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joerg Schad
> On March 28, 2016, 5:06 p.m., Cong Wang wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 311 > > > > > > This one breaks build even after all of your 7 patches are committed, > > because port_ma

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Cong Wang
I am wondering how does it pass your test since you did `make check` on both Linux and OSX? It fails immediately for me on Linux... On Mon, Mar 28, 2016 at 10:09 AM, Joris Van Remoortere wrote: > Joerg will fix these. > Thanks! > > On Mon, Mar 28, 2016 at 7:06 PM, Cong Wang wrote: > >> This is

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joris Van Remoortere
Joerg will fix these. Thanks! On Mon, Mar 28, 2016 at 7:06 PM, Cong Wang wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45230/ > 3rdparty/libprocess/include/process/subprocess.hpp >

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45230/#review125677 --- 3rdparty/libprocess/include/process/subprocess.hpp (line 301)

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45230/ --- (Updated March 28, 2016, 4:51 p.m.) Review request for mesos and Joris Van Remo

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45230/#review125637 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/subp

Re: Review Request 45230: Refactored subproces setup functions [1/7].

2016-03-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45230/ --- (Updated March 28, 2016, 11:42 a.m.) Review request for mesos and Joris Van Rem