Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-04-24 Thread Adam B
> On April 18, 2016, 5:03 p.m., Ben Mahler wrote: > > src/authorizer/local/authorizer.cpp, line 204 > > > > > > We generally avoid 'default' cases in enum switches because they allow > > the code to compile when a n

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-04-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review129450 --- src/authorizer/local/authorizer.cpp (line 204)

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125853 --- Patch looks great! Reviews applied: [45342] Passed command: expo

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Yong Tang
> On March 28, 2016, 10:23 p.m., Adam B wrote: > > Let's change the UNREACHABLE to an error+unauthorized. Thanks for the review Adam. I updated the review request. Let me know if the change meets the requirements or not. - Yong --- Thi

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/ --- (Updated March 29, 2016, 2:04 a.m.) Review request for mesos, Adam B, Anand Maz

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125768 --- Let's change the UNREACHABLE to an error+unauthorized. src/autho

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125725 --- Ship it! Ship It! - Vinod Kone On March 25, 2016, 8:13 p.m.,

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-28 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125618 --- Ship it! Ship It! - Adam B On March 25, 2016, 1:13 p.m., Yon

Re: Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125486 --- Patch looks great! Reviews applied: [45342] Passed command: expo

Review Request 45342: Make the Action enum optional to support upgrades (MESOS-5031).

2016-03-25 Thread Yong Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/ --- Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. Bugs: MESOS-5