Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review152636 --- Ship it! Committing with minor edits. src/slave/containerizer

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 13, 2016, 9:58 p.m., Jiang Yan Xu wrote: > > src/master/validation.cpp, lines 503-504 > > > > > > MESOS-6374 is where we want eventually but for now the same check is in > > `validateDiskInfo()` as well s

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Oct. 14, 2016, 3:23 a.m.) Review request for mesos, Greg Mann and Jian

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review152538 --- src/master/validation.cpp (lines 500 - 501)

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/filesystem/posix.hpp, line 55 > > > > > > If you end up removing the check for persistent volumes in this > > function per Y

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Oct. 13, 2016, 5:24 a.m.) Review request for mesos, Greg Mann and Jian

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 4:49 p.m., Jiang Yan Xu wrote: > > src/master/validation.hpp, lines 72-74 > > > > > > Not quite sure what `isTaskContext` is? We want to make sure persistent volumes when CREATEd have a mode as `R

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

> On Oct. 7, 2016, 5:49 p.m., Greg Mann wrote: > > src/examples/persistent_shared_volume_framework.cpp, line 191 > > > > > > s/used/uses/ It looks like this typo is still present? Or perhaps you meant to drop the

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review151731 --- See my comment in https://reviews.apache.org/r/45962/ as well; do

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/#review151802 --- - Can we move this patch to before the example framework so we can

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 28, 2016, 12:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 26, 2016, 11:50 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 22, 2016, 12:35 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Sept. 7, 2016, 5:57 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Aug. 25, 2016, 4:15 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated Aug. 4, 2016, 8:26 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 19, 2016, 10:53 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 18, 2016, 2:31 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated July 17, 2016, 6:29 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated June 23, 2016, 1:28 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated June 13, 2016, 7:20 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated May 22, 2016, 7:21 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated April 29, 2016, 12:16 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- (Updated April 9, 2016, 2:27 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 45963: Allow tasks to set persistent volume as readonly or readwrite resource.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45963/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-4324 https://issues.