Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/ --- (Updated April 14, 2016, 8:38 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-14 Thread Joris Van Remoortere
> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179 > > > > > > Can you explain why this is not defined on windows? > > Alex Clemmer

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-13 Thread Alex Clemmer
> On April 12, 2016, 2:41 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/tests/os/rmdir_tests.cpp, line 179 > > > > > > Can you explain why this is not defined on windows? Well, I don't

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-12 Thread Alex Naparu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128564 --- Ship it! Ship It! - Alex Naparu On April 10, 2016, 10:34

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-12 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128411 --- Fix it, then Ship it!

Re: Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/#review128036 --- Patch looks great! Reviews applied: [45898, 44090, 45888, 45940,

Review Request 45987: Fixed `rmdir.hpp` Windows build breaks.

2016-04-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45987/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris