Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Sept. 23, 2016, 8:17 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-19 Thread Qian Zhang
> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you add a test for this? > > Qian Zhang wrote: > Sure, I can add a test. I am just wondering how to use a test to verify > the logic we added in this patch, maybe we can just add a test to launch a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Vinod Kone
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you add a test for this? > > Qian Zhang wrote: > Sure, I can add a test. I am just wondering how to use a test to verify > the logic we added in this patch, maybe we can just add a test to launch a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review149146 --- Ship it! Ship It! - Vinod Kone On Sept. 15, 2016, 8:57

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Huadong Liu
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review149057 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Qian Zhang
> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-15 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Sept. 15, 2016, 4:57 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-14 Thread Huadong Liu
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-13 Thread Vinod Kone
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-13 Thread Qian Zhang
> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-13 Thread Vinod Kone
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-13 Thread Huadong Liu
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-13 Thread Qian Zhang
> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-09 Thread Vinod Kone
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp, line 682 > > > > > > hmm. what's the guarantee that an HTTP based executor receives an ACK > > within a second? what if the agent is

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review148042 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-07 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Sept. 7, 2016, 10:03 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-07 Thread Qian Zhang
> On Sept. 6, 2016, 7:33 p.m., Vinod Kone wrote: > > > > Vinod Kone wrote: > also, can you add a test for this? Sure, I can add a test. I am just wondering how to use a test to verify the logic we added in this patch, maybe we can just add a test to launch a short task and check

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-06 Thread Vinod Kone
> On Sept. 6, 2016, 11:33 a.m., Vinod Kone wrote: > > also, can you add a test for this? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review147808

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-09-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review147808 --- src/launcher/executor.cpp (lines 226 - 231)

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review147277 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-30 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Aug. 30, 2016, 2:01 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review147115 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-28 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Aug. 29, 2016, 11:06 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-26 Thread Qian Zhang
> On Aug. 26, 2016, 1:59 a.m., Vinod Kone wrote: > > qian, sorry for the delay on getting back on this one. are you still > > interested in seeing this through? if yes, can you please rebase? Sure Vinod, I will do the rebase later. - Qian

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146903 --- Bad patch! Reviews applied: [46187] Failed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated Aug. 25, 2016, 8:43 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-08-25 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review146821 --- qian, sorry for the delay on getting back on this one. are you

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-26 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated April 27, 2016, 9:23 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-25 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-25 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated April 25, 2016, 8:34 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review130285 --- Patch looks great! Reviews applied: [46187] Passed command:

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- (Updated April 24, 2016, 8:18 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-23 Thread Qian Zhang
> On April 15, 2016, 12:49 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-23 Thread Qian Zhang
> On April 15, 2016, 12:49 a.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-21 Thread Vinod Kone
> On April 14, 2016, 4:49 p.m., Vinod Kone wrote: > > src/launcher/http_command_executor.cpp, line 749 > > > > > > Looking at slave::statusUpdate() code there are several scenarios where > > the slave ignores a

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review128916 --- src/launcher/http_command_executor.cpp

Re: Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/#review128848 --- Patch looks great! Reviews applied: [46187] Passed command:

Review Request 46187: Terminate when receiving the ACK of terminal status update.

2016-04-13 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46187/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-3558