Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129184 --- Ship it! Ship It! - Vinod Kone On April 15, 2016, 6:55 p.m.,

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- (Updated April 15, 2016, 6:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Vinod Kone
> On April 14, 2016, 5:33 p.m., Greg Mann wrote: > > src/master/flags.cpp, lines 225-226 > > > > > > This seems a tiny bit misleading: if the value is `false`, no > > authentication will be performed at all. Perhaps

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- (Updated April 15, 2016, 4:39 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
- Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129044 --- On April 15, 2016, 4:39 p.m., Anand Mazumdar wrote: > >

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-15 Thread Anand Mazumdar
> On April 15, 2016, 12:42 a.m., Vinod Kone wrote: > > src/master/flags.cpp, line 482 > > > > > > do we need a default here? we needed a default for > > `--http_authenticators` for backwards compatibility. since the

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review129044 --- src/master/constants.hpp (line 132)

Re: Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-14 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/#review128925 --- src/master/flags.cpp (lines 225 - 226)

Review Request 46211: Added flags for authenticating HTTP frameworks to master.

2016-04-14 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46211/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3923 https://issues.ap