Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-05-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review132617 --- Ship it! Ship It! - Michael Park On May 10, 2016, 8:08

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-05-05 Thread Michael Park
> On May 4, 2016, 10:53 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2240-2270 > > > > > > Consider this if you would to preserve the guarantee: > > > > ```cpp > > struct

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-05-05 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/ --- (Updated May 5, 2016, 3:55 p.m.) Review request for mesos, Alex Naparu, Daniel

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-05-05 Thread Alex Clemmer
> On May 4, 2016, 10:53 p.m., Michael Park wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2240-2270 > > > > > > Consider this if you would to preserve the guarantee: > > > > ```cpp > > struct

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-05-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review131755 --- 3rdparty/libprocess/src/process.cpp (lines 896 - 897)

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-23 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/ --- (Updated April 23, 2016, 11:26 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-23 Thread Alex Clemmer
> On April 22, 2016, 10:04 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, line 897 > > > > > > space between `(char*)` and `` Let's actually make it a C++ cast. - Alex

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review130196 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/#review129644 --- Patch looks great! Reviews applied: [46393, 46395] Passed

Review Request 46395: Windows: Removed `std::bind` from `process.cpp` to build on Windows.

2016-04-19 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46395/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris