Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-09 Thread Joseph Wu
> On May 6, 2016, 12:37 a.m., Adam B wrote: > > Please create a JIRA with motivation for this hook. I don't want a new hook > > to slip into a release without a JIRA in the changelog to document it. > > Kapil Arya wrote: > Good point. I meant to add it to the RR, but it slipped :-). I shou

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-06 Thread Kapil Arya
> On May 6, 2016, 3:37 a.m., Adam B wrote: > > Please create a JIRA with motivation for this hook. I don't want a new hook > > to slip into a release without a JIRA in the changelog to document it. Good point. I meant to add it to the RR, but it slipped :-). - Kapil

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131997 --- Please create a JIRA with motivation for this hook. I don't want a

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131966 --- Ship it! Ship It! - Kapil Arya On May 5, 2016, 12:01 p.m., J

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-05 Thread Kapil Arya
> On May 5, 2016, 1:27 p.m., Kapil Arya wrote: > > The hooks looks good but I have a high-level question. Instead of having > > two separate hooks for validation and label-decoration, I am wondering, if > > we can have one consolidated hook. That hook would then update the labels > > (and any

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-05 Thread Joseph Wu
> On May 5, 2016, 10:27 a.m., Kapil Arya wrote: > > The hooks looks good but I have a high-level question. Instead of having > > two separate hooks for validation and label-decoration, I am wondering, if > > we can have one consolidated hook. That hook would then update the labels > > (and any

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131869 --- The hooks looks good but I have a high-level question. Instead of

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-03 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/#review131567 --- Patch looks great! Reviews applied: [46920] Passed command: expo

Re: Review Request 46920: Added validation hook inside Slave::runTask.

2016-05-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46920/ --- (Updated May 3, 2016, 1:50 p.m.) Review request for mesos, Adam B, Artem Haruty