Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review167321 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-27 Thread Guangya Liu
> On 五月 25, 2016, 4:41 p.m., Shuai Lin wrote: > > src/slave/slave.cpp, line 3454 > > > > > > Should we also search in in `termiantedTasks`? > > > > ```cpp > > // Terminated but pending updates. > >

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review135198 --- Srini, please add MESOS-4135 to `Bugs` filed at right-top of the p

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-25 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134782 --- src/slave/slave.cpp (line 3454)

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-25 Thread Shuai Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134778 --- Sometimes mesos master would also send status update to the framew

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134390 --- src/tests/slave_tests.cpp (line 3265)

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-23 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134388 --- Is there a use case or JIRA ticket for this change? Wanted to unde

Re: Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/#review134070 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 47608: Add Labels from TaskInfo into TaskStatus message.

2016-05-19 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47608/ --- Review request for mesos. Repository: mesos Description --- WIP: Add Lab