Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review135406 --- Ship it! LGTM modulo the comments I made. I'll fix them when co

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 384 > > > > > > s/slaveFlags/slave->flags/, see comment above. don't need to pass the flags at all since this is now a member function.

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134950 --- Ship it! Ship It! - Jan Schlicht On May 25, 2016, 6:27 p.m.,

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134788 --- Patch looks great! Reviews applied: [47822] Passed command: expo

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/ --- (Updated May 25, 2016, 4:27 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/ --- (Updated May 25, 2016, 4:26 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 11:45 a.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 379 > > > > > > Why was this needed? IMHO the existing explicitness helps to document > > what state we drag into the lambdas and s

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 11:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 651 > > > > > > Remove this, same rationale as the comments in `Slave::Http::flags`. > > Abhishek Dasgupta wrote: > One thing I wan

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Benjamin Bannier wrote: > > src/slave/http.cpp, line 379 > > > > > > Why was this needed? IMHO the existing explicitness helps to document > > what state we drag into the lambdas and sh

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

> On May 25, 2016, 9:45 a.m., Jan Schlicht wrote: > > src/slave/http.cpp, line 651 > > > > > > Remove this, same rationale as the comments in `Slave::Http::flags`. One thing I want to be sure here: "pid" is getting

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134746 --- Patch looks great! Reviews applied: [47822] Passed command: expo

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134744 --- LGTM. I left a few comments. src/slave/http.cpp (line 379)

Re: Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/#review134743 --- Thanks for taking this on! Please keep in mind that to work around

Review Request 47822: Removed inconsistancy from routing endpoints in agent code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47822/ --- Review request for mesos, Adam B, Alexander Rukletsov, Anand Mazumdar, Benjamin