Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 19, 2016, 9:27 p.m., Kevin Klues wrote: > > src/tests/api_tests.cpp, lines 419-421 > > > > > > It's not here in the review, but the final committed version of this > > patch contains these lines as: > >

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138482 --- src/tests/api_tests.cpp (lines 419 - 421)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138434 --- Fix it, then Ship it! Thanks for the patience Abhishek. I

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach`

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138427 --- Patch looks great! Reviews applied: [48094] Passed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5 p.m., haosdent huang wrote: > > src/master/http.cpp, lines 1465-1473 > > > > > > Same here, I think could > > ``` > > Role* role = master->activeRoles[name]; > > > >

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5:33 p.m., Abhishek Dasgupta wrote: > > src/tests/api_tests.cpp, lines 459-475 > > > > > > v1Response->get_roles().roles() returns a protobuf repeated pointer > > field. Would it not be a

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 5 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, lines 459-475 > > > > > > I suggest change this to > > ``` > > v1::Resources expectedResources = > >

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138416 --- src/tests/api_tests.cpp (lines 459 - 475)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138413 --- Ship it! LGTM if besides some isssues mentioned above. -

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138412 --- src/master/http.cpp (lines 1456 - 1460)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 18, 2016, 4:21 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach`

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 18, 2016, 2:43 p.m., haosdent huang wrote: > > src/tests/api_tests.cpp, line 456 > > > > > > I think we could not gruantee the `v1Response->get_roles().roles(2)` > > equal to `role2`. How about `foreach`

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138405 --- src/master/http.cpp (line 1456)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138401 --- Patch looks great! Reviews applied: [48094] Passed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 18, 2016, 11:23 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138342 --- Just a few more minor comments. Looks pretty good otherwise!

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138201 --- Patch looks great! Reviews applied: [48094] Passed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

> On June 17, 2016, 6:29 a.m., haosdent huang wrote: > > src/master/http.cpp, line 2485 > > > > > > Hi, @a10gupta Could not got the idea that why you rename to `_roles` > > here. Seems you have never reuse this

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 17, 2016, 8:30 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138169 --- src/master/http.cpp (line 2485)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review138016 --- Bad patch! Reviews applied: [48094] Failed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 16, 2016, 10:48 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review137062 --- Patch looks great! Reviews applied: [48094] Passed command:

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 10, 2016, 7:13 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- (Updated June 10, 2016, 6:45 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review136539 --- include/mesos/v1/master.proto (lines 273 - 285)

Re: Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/#review135736 --- Patch looks great! Reviews applied: [48094] Passed command:

Review Request 48094: Implemented GET_ROLES Call in v1 master API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48094/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-5494