Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-15 Thread Jiang Yan Xu
> On July 13, 2016, 4:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-15 Thread Anindya Sinha
> On July 13, 2016, 11:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-13 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 14, 2016, 12:11 a.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-13 Thread Anindya Sinha
> On July 13, 2016, 11:04 a.m., Neil Conway wrote: > > BTW, one thought: rather than writing out a new checkpoint and then > > deleting the target checkpoint file, what about renaming target -> current > > checkpoint? Rename is typically atomic (within a single filesystem), which > > is nice,

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review142052 --- BTW, one thought: rather than writing out a new checkpoint and

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review142007 --- Ship it! Ship It! - Jiang Yan Xu On July 12, 2016, 1:25

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-12 Thread Anindya Sinha
> On July 12, 2016, 5:29 p.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, line 4803 > > > > > > "or no target resources are present": We are inside the > > > > ``` > > if

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-12 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 12, 2016, 8:25 p.m.) Review request for mesos, Neil Conway and

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/#review141912 --- Fix it, then Ship it! src/slave/paths.hpp (lines 63 - 68)

Re: Review Request 48313: Consistency in persistent volumes between master and agent on failure.

2016-07-11 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48313/ --- (Updated July 11, 2016, 9:42 p.m.) Review request for mesos, Neil Conway and