Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On July 12, 2016, 9:25 a.m., Neil Conway wrote: > > Is this change still necessary, given the changes in > > https://reviews.apache.org/r/48313 ? I'd prefer to keep the ability to > > create `MOUNT` volumes on existing filesystem content. > > Anindya Sinha wrote: > Without this change, w

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On July 12, 2016, 9:25 a.m., Neil Conway wrote: > > Is this change still necessary, given the changes in > > https://reviews.apache.org/r/48313 ? I'd prefer to keep the ability to > > create `MOUNT` volumes on existing filesystem content. > > Anindya Sinha wrote: > Without this change, w

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On July 12, 2016, 9:25 a.m., Neil Conway wrote: > > Is this change still necessary, given the changes in > > https://reviews.apache.org/r/48313 ? I'd prefer to keep the ability to > > create `MOUNT` volumes on existing filesystem content. Without this change, we run the possibility of exposi

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review141870 --- Is this change still necessary, given the changes in https://revi

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review140466 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated July 1, 2016, 9:41 p.m.) Review request for mesos, Neil Conway and Jia

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 23, 2016, 10:30 a.m., Neil Conway wrote: > > Can you write a unit test that verifies the main functional change in this > > review? That is, if the user attempts to create a persistent volume on a > > path that already contains files, the creation fails and the slave exits > > with a

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review139231 --- Can you write a unit test that verifies the main functional change

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review138762 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 20, 2016, 11:41 p.m.) Review request for mesos, Neil Conway and J

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review137935 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 14, 2016, 8:45 a.m., Neil Conway wrote: > > src/slave/slave.cpp, line 2540 > > > > > > I think this justifies a unit test. What do you think? Added checks in unit test to verify that contents of directory

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 15, 2016, 11:01 p.m.) Review request for mesos, Neil Conway and J

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review137467 --- src/slave/slave.cpp (line 2540)

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review137397 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 13, 2016, 9:03 p.m.) Review request for mesos, Neil Conway and Ji

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 8, 2016, 1:06 p.m., Neil Conway wrote: > > (1) This could benefit from a unit test. > > > > (2) More importantly, what happens if the directory already exists and > > contains data? By "cleanup", you mean delete any existing data in the > > directory, right? ISTM this could very easi

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136785 --- src/slave/slave.cpp (line 2541)

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136755 --- Patch looks great! Reviews applied: [48313, 48314, 48315] Passed

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- (Updated June 9, 2016, 12:25 a.m.) Review request for mesos, Neil Conway and Ji

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

> On June 8, 2016, 1:06 p.m., Neil Conway wrote: > > (1) This could benefit from a unit test. > > > > (2) More importantly, what happens if the directory already exists and > > contains data? By "cleanup", you mean delete any existing data in the > > directory, right? ISTM this could very easi

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136633 --- (1) This could benefit from a unit test. (2) More importantly, wh

Re: Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review136406 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Review Request 48315: Restart slave if a volume is CREATED on a non-empty path.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/ --- Review request for mesos. Bugs: MESOS-5448 https://issues.apache.org/jira/b