Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review138939 --- Ship it! src/master/allocator/sorter/drf/sorter.cpp (lines

Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-21 Thread Benjamin Mahler
> On June 21, 2016, 8:35 p.m., Benjamin Mahler wrote: > > It looks like dirty is not being set to true in all cases. For example, > > when the weights are updated, why aren't we setting dirty to true? Just saw that you fixed this in your next patch, I'll go through this again shortly, should

Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review138928 --- It looks like dirty is not being set to true in all cases. For

Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-11 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/ --- (Updated 六月 11, 2016, 8:30 a.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 48579: Reset "dirty" to false in sort().

2016-06-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/#review137099 --- src/master/allocator/sorter/drf/sorter.cpp (lines 137 - 142)

Review Request 48579: Reset "dirty" to false in sort().

2016-06-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48579/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Bugs: MESOS-5600