Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138583 --- Patch looks great! Reviews applied: [48613, 48901, 48614] Passed

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-19 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 20, 2016, 5:41 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138505 --- Ship it! Ship It! - Vinod Kone On June 18, 2016, 9:16 p.m.,

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138441 --- Patch looks great! Reviews applied: [48613, 48901, 48614] Passed

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 9:16 p.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review138394 --- Bad patch! Reviews applied: [48614, 48901, 48613] Failed command

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 8:21 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 8:20 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- (Updated June 18, 2016, 7:58 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-18 Thread Deshna Jain
> On June 13, 2016, 7:41 a.m., Neil Conway wrote: > > src/tests/scheduler_http_api_tests.cpp, line 974 > > > > > > Why are we fetching the stream ID? > > Vinod Kone wrote: > looks like you forgot to set the stre

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-13 Thread Vinod Kone
> On June 13, 2016, 7:41 a.m., Neil Conway wrote: > > src/tests/scheduler_http_api_tests.cpp, line 974 > > > > > > Why are we fetching the stream ID? looks like you forgot to set the stream ID header when sending th

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-13 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review137407 --- src/master/validation.cpp (line 308)

Re: Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/#review137239 --- Nice first patch to Mesos! I wonder whether it would be safer to

Review Request 48614: Added validation for UUID's to master/agent validation helpers.

2016-06-12 Thread Deshna Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48614/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-5224 https://issues.ap