Re: Review Request 48906: Added helper function to get non-scarce resources.

2016-06-22 Thread Benjamin Mahler
> On June 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just

Re: Review Request 48906: Added helper function to get non-scarce resources.

2016-06-21 Thread Guangya Liu
> On 六月 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just use

Re: Review Request 48906: Added helper function to get non-scarce resources.

2016-06-21 Thread Benjamin Mahler
> On June 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just

Re: Review Request 48906: Added helper function to get non-scarce resources.

2016-06-21 Thread Guangya Liu
> On 六月 21, 2016, 10:36 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 252-256 > > > > > > The Resources abstraction shouldn't need to know anything about scarce > > resources, you can just use

Re: Review Request 48906: Added helper function to get non-scarce resources.

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48906/#review138958 --- include/mesos/resources.hpp (lines 252 - 256)

Review Request 48906: Added helper function to get non-scarce resources.

2016-06-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48906/ --- Review request for mesos and Benjamin Mahler. Bugs: MESOS-5621