Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-21 Thread Tomasz Janiszewski
> On Cze 21, 2016, 9:32 po poĊ‚udniu, Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? > > Tomasz Janiszewski wrote: > How about adding "Connected" column with plain true

Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-21 Thread Benjamin Mahler
> On June 21, 2016, 9:32 p.m., Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? > > Tomasz Janiszewski wrote: > How about adding "Connected" column with plain true/false

Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-21 Thread Tomasz Janiszewski
> On June 21, 2016, 9:32 p.m., Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? How about adding "Connected" column with plain true/false or status icon? - Tomasz --

Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138945 --- Very nice, however the meaning of the color doesn't seem discovera

Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138435 --- Ship it! Nice patch! - haosdent huang On June 18, 2016, 7:16

Re: Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138430 --- Patch looks great! Reviews applied: [48910] Passed command: expo

Review Request 48910: Highlight disconnected frameworks in webui.

2016-06-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/ --- Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross All