Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-20 Thread Zhitao Li
> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 262 > > > > > > Is libelf a run-time dep as well? I thought it was a build-time dep > > only? I'm thinking more and more that we should gu

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread haosdent huang
> On June 20, 2016, 1:59 a.m., haosdent huang wrote: > > docs/upgrades.md, line 257 > > > > > > I saw the `getting-started.md` use `elfutils-libelf-devel.x86_64`, > > seems not match here? > > Kevin Klues wrote: >

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 1:59 a.m., haosdent huang wrote: > > docs/upgrades.md, line 257 > > > > > > I saw the `getting-started.md` use `elfutils-libelf-devel.x86_64`, > > seems not match here? The getting started guide

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138513 --- Fix it, then Ship it! docs/upgrades.md (line 257)

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 255 > > > > > > s/dependence/dependency/ ? > > > > esp the last occurence in this para. I can make the change if you like, but wh

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
> On June 20, 2016, 12:34 a.m., Vinod Kone wrote: > > docs/upgrades.md, line 262 > > > > > > Is libelf a run-time dep as well? I thought it was a build-time dep > > only? I'm thinking more and more that we should gu

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138508 --- Patch looks great! Reviews applied: [48912, 48913, 48914, 48915,

Re: Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/#review138506 --- docs/upgrades.md (line 255)

Review Request 48928: Added info about external `libelf` dependence to `upgrades.md`.

2016-06-19 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48928/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Vinod Kone, and Zhita