Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139730 --- Ship it! Ship It! - Vinod Kone On June 28, 2016, 5:21 a.m.,

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
> On 六月 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1103 > > > > > > I think I missed this in the previous review, but lets call this `get` > > as well. Do this in a different review. Th

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/ --- (Updated 六月 28, 2016, 5:21 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139649 --- any updates on this? - Vinod Kone On June 23, 2016, 6:04 a.m.,

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread Vinod Kone
> On June 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. > > zhou

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread haosdent huang
> On June 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. > > zhou

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-27 Thread zhou xing
> On 六月 24, 2016, 9:57 p.m., Vinod Kone wrote: > > src/master/weights_handler.cpp, line 216 > > > > > > why this change? looks like we want a sanitized role (#193) to be > > inside validatedWeightInfos. Vinod, at l

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139409 --- src/master/master.hpp (line 1103)

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-22 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/ --- (Updated 六月 23, 2016, 6:04 a.m.) Review request for mesos, Anand Mazumdar, haos

Re: Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/#review139063 --- src/master/master.hpp (line 1131)

Review Request 48940: Extract public logic of updating weights into _updateWeights.

2016-06-21 Thread zhou xing
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48940/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. Bugs: