Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-22 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/#review139149 --- Ship it! Ship It! - Benjamin Mahler On June 22, 2016, 9:51

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-22 Thread Qian Zhang
> On June 22, 2016, 6:05 a.m., Benjamin Mahler wrote: > > Can you describe why you made this change? > > > > This follows the same pattern as other isolators (e.g. cpushare.cpp, > > mem.cpp), so it's hard to tell what the issue is here. > > Qian Zhang wrote: > I think for

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-21 Thread Benjamin Mahler
> On June 21, 2016, 10:05 p.m., Benjamin Mahler wrote: > > Can you describe why you made this change? > > > > This follows the same pattern as other isolators (e.g. cpushare.cpp, > > mem.cpp), so it's hard to tell what the issue is here. > > Qian Zhang wrote: > I think for

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-21 Thread Qian Zhang
> On June 22, 2016, 6:05 a.m., Benjamin Mahler wrote: > > Can you describe why you made this change? > > > > This follows the same pattern as other isolators (e.g. cpushare.cpp, > > mem.cpp), so it's hard to tell what the issue is here. I think for `cgroups/devices` isolator, we need to

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/#review138951 --- Can you describe why you made this change? This follows the same

Re: Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/#review138822 --- Patch looks great! Reviews applied: [49013] Passed command:

Review Request 49013: Updated cgroups/devices isolator's prepare() to directly return None().

2016-06-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49013/ --- Review request for mesos, Benjamin Mahler and Kevin Klues. Bugs: MESOS-5582