Re: Review Request 49207: Added proto message definitions to support appc runtime.

2017-05-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review174485 --- include/mesos/appc/spec.proto Lines 51 (patched)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-07-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review140313 --- Srini, this patch was already merged, why are you continually

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-30 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 30, 2016, 6 a.m.) Review request for mesos, Gilbert Song and Jie

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-29 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 30, 2016, 5:38 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139936 --- include/mesos/appc/spec.proto (line 43)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139921 --- include/mesos/appc/spec.proto (line 43)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139873 --- Ship it! Ship It! - Jie Yu On June 28, 2016, 9:45 p.m.,

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Srinivas Brahmaroutu
> On June 25, 2016, 9:16 a.m., Guangya Liu wrote: > > @gyliu, This spec is referred at the top of the file. I am dropping this issue. - Srinivas --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Srinivas Brahmaroutu
> On June 28, 2016, 1:11 p.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, lines 44-46 > > > > > > I saw that you dropped previous comments, but it would be great if you > > can show some comments to

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Srinivas Brahmaroutu
> On June 26, 2016, 1:57 a.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, line 50 > > > > > > What about `optional Environment environment = 3;` We thought of duplicating "Label" as another message

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139774 --- include/mesos/appc/spec.proto (lines 44 - 46)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-27 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 28, 2016, 5:05 a.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-27 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139614 --- include/mesos/appc/spec.proto (lines 43 - 46)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139465 --- include/mesos/appc/spec.proto (line 44)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-25 Thread Guangya Liu
> On 六月 25, 2016, 9:16 a.m., Guangya Liu wrote: > > include/mesos/appc/spec.proto, lines 44-46 > > > > > > Can you please put the link of > > https://github.com/appc/spec/blob/master/spec/aci.md here for reference?

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-25 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 25, 2016, 4:08 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-25 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/#review139431 --- include/mesos/appc/spec.proto (lines 44 - 46)

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-24 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 24, 2016, 11:20 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-24 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- (Updated June 24, 2016, 9:57 p.m.) Review request for mesos. Repository:

Review Request 49207: Added proto message definitions to support appc runtime.

2016-06-24 Thread Srinivas Brahmaroutu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49207/ --- Review request for mesos. Repository: mesos Description --- Added proto