Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140541 --- Ship it! Ship It! - Jie Yu On July 2, 2016, 9:50 p.m.,

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

> On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580 > > > > > > Please use UUID::random here. > > Haris Choudhary wrote: > I've made the changes. But

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140521 --- Patch looks great! Reviews applied: [49414] Passed command:

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

> On July 2, 2016, 5:46 a.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 580 > > > > > > Please use UUID::random here. I've made the changes. But consider if both UUID's were the

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/ --- (Updated July 2, 2016, 9:50 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140485 --- Seems most comments are style issue, so I would suggest that you

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140480 --- Bad patch! Reviews applied: [49414] Failed command:

Re: Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/#review140479 --- src/slave/containerizer/mesos/launcher.hpp (line 78)

Review Request 49414: Added Executor PID in /containers endpoint. Also Added Test Cases.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49414/ --- Review request for mesos and Jie Yu. Bugs: MESOS-5737