Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- (Updated July 6, 2016, 11:37 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review141035 --- Ship it! Ship It! - Adam B On July 6, 2016, 8:13 a.m., Abhis

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was taking mesos::Request and giving compiler e

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- (Updated July 6, 2016, 3:13 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.hpp, line 65 > > > > > > Shame we have to perpetuate these naked pointers. Any chance we could > > use a `shared_ptr`? > > Abhishek Dasgupta wrote: >

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 12:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 3:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was taking mesos::Request and giving compiler er

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140928 --- Patch looks great! Reviews applied: [49600] Passed command: expo

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 3:04 a.m., Adam B wrote: > > src/files/files.hpp, line 65 > > > > > > Shame we have to perpetuate these naked pointers. Any chance we could > > use a `shared_ptr`? > > Abhishek Dasgupta wrote: >

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 12:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > > > > > Why did these have to move? > > Abhishek Dasgupta wrote: > Or else, it was taking mesos::Request and giving compiler e

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- (Updated July 5, 2016, 8:08 p.m.) Review request for mesos, Adam B, Alexander R

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.hpp, line 65 > > > > > > Shame we have to perpetuate these naked pointers. Any chance we could > > use a `shared_ptr`? It looks we have to change meso

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 7:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 9:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 10:04 a.m., Adam B wrote: > > src/files/files.cpp, lines 89-90 > > > > > > Why did these have to move? Or else, it was taking mesos::Request and giving compiler error. Should we use direct scope r

Re: Review Request 49600: Added authz to /files/debug endpoint.

> On July 5, 2016, 7:03 a.m., Alexander Rojas wrote: > > src/files/files.cpp, lines 729-731 > > > > > > The lambda doesn't use any method nor attribute from `FilesProcess`, so > > you can save the `defer()` call as

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140738 --- Looks good overall. I have just a few minor suggestions, and once

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140726 --- src/files/files.cpp (lines 726 - 728)

Re: Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/#review140703 --- Patch looks great! Reviews applied: [49600] Passed command: expo

Review Request 49600: Added authz to /files/debug endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49600/ --- Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and Jan