Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-11 Thread Neil Conway
> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-06 Thread Alexander Rukletsov
> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Neil Conway
> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Alexander Rukletsov
> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Neil Conway
> On July 5, 2016, 3:08 p.m., Alexander Rukletsov wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3100 > > > > > > I would keep these 3 instances in this test. It's not immediately clear > > that

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/#review140790 --- Fix it, then Ship it!

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/#review140753 --- Patch looks great! Reviews applied: [49610, 49612] Passed

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-05 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/ --- (Updated July 5, 2016, 8:51 a.m.) Review request for mesos and Alexander

Re: Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/#review140713 --- Patch looks great! Reviews applied: [49610, 49612] Passed

Review Request 49612: Removed unnecessary `Clock::settle` calls from test cases.

2016-07-04 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49612/ --- Review request for mesos and Alexander Rukletsov. Repository: mesos