Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 19, 2016, 12:57 a.m., Vinod Kone wrote: > > This change looks ok to me and indepdendent of the previous 2 reviews in > > the chain. If yes, I'm happy to commit this if you remove the dependency. > > You might be able to discard the first 2 reviews even. I discarded the first one,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142674 --- Ship it! This change looks ok to me and indepdendent of the

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142538 --- Bad patch! Reviews applied: [49914, 50072, 49913] Failed

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 18, 2016, 8:20 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 18, 2016, 8:19 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 13, 2016, 10:09 a.m., Neil Conway wrote: > > src/tests/api_tests.cpp, line 95 > > > > > > Rather than changing this for all tests implicitly, I'd prefer creating > > a `master::Flags` and changing the

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- (Updated July 15, 2016, 3:33 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 13, 2016, 10:09 a.m., Neil Conway wrote: > > src/tests/api_tests.cpp, line 95 > > > > > > Rather than changing this for all tests implicitly, I'd prefer creating > > a `master::Flags` and changing the

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142046 --- src/tests/api_tests.cpp (line 95)

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

> On July 12, 2016, 12:35 p.m., Neil Conway wrote: > > Seems like this review contains a bunch of changes, in addition to lowering > > the `allocation_interval`. Are these changes related? Can you move the > > unrelated changes to a separate review, and/or explain why you have made > > them?

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review141889 --- Seems like this review contains a bunch of changes, in addition

Re: Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review141802 --- Patch looks great! Reviews applied: [49913, 49914] Passed

Review Request 49914: Improved the speed of 'MasterAPITest.UnreserveResources'.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/ --- Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. Bugs: