Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 25, 2016, 4:59 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 49926: Added Windows build batch script.

> On July 12, 2016, 9:40 p.m., Alex Clemmer wrote: > > support/windows-build.bat, line 44 > > > > > > Heh. Do we want to actually explain that this is a bug? This comment > > seems more like an inside joke right now.

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review143433 --- Ship it! Ship It! - Alex Clemmer On July 12, 2016, 11:16 p.m

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141977 --- Patch looks great! Reviews applied: [49926] Passed command: expo

Re: Review Request 49926: Added Windows build batch script.

> On July 12, 2016, 2:40 p.m., Alex Clemmer wrote: > > support/windows-build.bat, lines 32-33 > > > > > > I'm not super familiar with Jenkins, but I wonder why we create `tmp` > > in the Jenkins script, but create `b

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 12, 2016, 4:16 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141965 --- support/windows-build.bat (line 1)

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 11, 2016, 6:11 p.m.) Review request for mesos, Daniel Pravat, Art

Re: Review Request 49926: Added Windows build batch script.

> On July 11, 2016, 5:35 p.m., Daniel Pravat wrote: > > support/windows-build.bat, line 71 > > > > > > If you add one more target Clean you don't need to delete any folder. Do you mean the "build/include" and "build

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141804 --- support/windows-build.bat (line 71)

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/#review141793 --- LGTM from what I can understand. I'll let the Microsoft Guys take

Re: Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- (Updated July 11, 2016, 3:19 p.m.) Review request for mesos, Daniel Pravat, Art

Review Request 49926: Added Windows build batch script.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49926/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, and Alex Clemmer. B