Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review152628 --- src/local/local.cpp (line 183)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated Aug. 10, 2016, 11:28 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review145425 --- can you rebase? - Vinod Kone On July 21, 2016, 1:38 a.m., Ammar

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On Aug. 6, 2016, 12:29 a.m., Vinod Kone wrote: > > src/local/local.cpp, lines 179-180 > > > > > > not sure if 'propagated_flags' is the right name. > > > > also, wondering if it would be intuitive to just

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On Aug. 6, 2016, 12:29 a.m., Vinod Kone wrote: > > src/local/local.cpp, lines 179-180 > > > > > > not sure if 'propagated_flags' is the right name. > > > > also, wondering if it would be intuitive to just

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review145011 --- Fix it, then Ship it! src/local/local.cpp (lines 179 - 180)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 25, 2016, 6:04 p.m., Greg Mann wrote: > > Thanks Ammar! Patches look good to me; Vinod is going to take a look when > > he has some cycles. bump - Ammar --- This is an automatically generated e-mail. To reply, visit: https://

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review143085 --- Thanks Ammar! Patches look good to me; Vinod is going to take a lo

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review143076 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 21, 2016, 1:38 a.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142973 --- src/local/flags.hpp (line 50)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142928 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 20, 2016, 5:10 a.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142791 --- Fix it, then Ship it! src/local/flags.hpp (lines 33 - 34)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142689 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 18, 2016, 10:30 p.m., Greg Mann wrote: > > src/tests/test_framework_test.sh, line 24 > > > > > > I see what you mean about the failure of these `atexit` statements - I > > also see lots of litter in my /tmp

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 18, 2016, 10:51 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142588 --- src/local/flags.hpp (lines 33 - 37)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142479 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 16, 2016, 2:14 a.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142468 --- Bad patch! Reviews applied: [50003, 50002] Failed command: ./sup

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 15, 2016, 5:41 p.m., Greg Mann wrote: > > src/local/flags.hpp, line 33 > > > > > > I was originally put off by the duplication of the `work_dir` flag > > here, since it makes `work_dir` the only normal Meso

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

> On July 15, 2016, 5:41 p.m., Greg Mann wrote: > > Regarding the regression test: several of our tests use this "local mode" > > to test example frameworks (see 'src/tests/examples_tests.cpp'), but they > > all set the MESOS_WORK_DIR env var before running. I also noticed that we > > don't ha

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 15, 2016, 9:01 p.m.) Review request for mesos, Greg Mann and Vino

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142393 --- Regarding the regression test: several of our tests use this "loca

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142324 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- (Updated July 14, 2016, 10:11 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142254 --- src/local/flags.hpp (line 36)

Re: Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142179 --- Patch looks great! Reviews applied: [50002, 50003] Passed comman

Review Request 50003: Propagate work_dir flag from local runs to agents/masters.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-5613 https: