Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review154668 --- Fix it, then Ship it! It would be great to describe the

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On Oct. 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 2161 > > > > > > Maybe consider using a ":" here instead of a comma? > > Guangya Liu wrote: > After a second

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 2, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review154404 --- Fix it, then Ship it! Ship It!

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Nov. 1, 2016, 6:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 26, 2016, 3:22 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 2161 > > > > > > Maybe consider using a ":" here instead of a comma? After a second thought, I'm not sure if using a

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Oct. 31, 2016, 7:09 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153837 --- src/slave/containerizer/docker.cpp (line 2155)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated Oct. 24, 2016, 4:59 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153632 --- src/slave/containerizer/docker.hpp (line 259)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 9:10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153506 --- Fix it, then Ship it! Ship It!

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 21, 2016, 6:28 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 20, 2016, 1:32 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2154-2158 > > > > > > Do you have a patch for removing this comment? Yes, removed it in

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153384 --- src/slave/containerizer/docker.hpp (lines 259 - 260)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 20, 2016, 10 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review153021 --- src/slave/containerizer/docker.hpp (lines 258 - 274)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 14, 2016, 9:56 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 13, 2016, 10:14 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 11, 2016, 3:40 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2150-2151 > > > > > > Here will cause failure if gpu is not enabled, the ideal logic could be: > > > > ``` > >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 12, 2016, 7:31 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 643-696 > > > > > > I was thinking for how to make less code change but need to make sure > > build passed on mac. > >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review152277 --- src/slave/containerizer/docker.cpp (lines 643 - 696)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review152140 --- src/slave/containerizer/docker.cpp (lines 2147 - 2148)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 十月 11, 2016, 8:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 十月 9, 2016, 5:16 a.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 2105-2109 > > > > > > Not yours, but I think that the comments can be removed as we have the > > logic of killing those

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review151477 --- src/slave/containerizer/docker.cpp (lines 648 - 649)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 28, 2016, 12:57 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, line 506 > > > > > > Shoud we use `set` here like we do in the mesos containerizer? Yes, changed it to `set`. > On 八月 28,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 22, 2016, 6:16 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 20, 2016, 9:22 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 九月 19, 2016, 7:17 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 666-668 > > > > > > I would do this as the first check in this function. If we don't have > > an allocator set, then

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 505-507 > > > > > > I would just call this variable `gpus` > > Also the comment should read: > > ``` > >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, lines 666-668 > > > > > > I would do this as the first check in this function. If we don't have > > an allocator set, then

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review147089 --- src/slave/containerizer/docker.hpp (line 506)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 26, 2016, 11:02 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.hpp, lines 505-507 > > > > > > I would just call this variable `gpus` > > Also the comment should read: > > ``` > > //

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On Aug. 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1555 > > > > > > I wouldn't just blindly call this function here. It should be wrapped > > in some logic that makes

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 25, 2016, 12:32 a.m., Kevin Klues wrote: > > src/slave/containerizer/docker.cpp, line 1555 > > > > > > I wouldn't just blindly call this function here. It should be wrapped > > in some logic that makes

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146726 --- src/slave/containerizer/docker.hpp (lines 505 - 507)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 22, 2016, 10:11 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146313 --- src/slave/containerizer/docker.cpp (lines 698 - 716)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review146301 --- src/slave/containerizer/docker.hpp (line 505)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 16, 2016, 10:19 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145747 --- src/slave/containerizer/docker.hpp (line 255)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 15, 2016, 7:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

> On 八月 11, 2016, 3:07 p.m., Guangya Liu wrote: > > src/slave/containerizer/docker.cpp, lines 1325-1355 > > > > > > What about adding a new function named as > > `DockerContainerizerProcess::allocateNvidiaGpu`. >

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145507 --- src/slave/containerizer/docker.hpp (lines 215 - 218)

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 10, 2016, 10:34 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- (Updated 八月 9, 2016, 9:25 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/#review145056 --- src/slave/containerizer/docker.cpp (lines 1360 - 1428)

Review Request 50841: Added GPU scheduling logic to docker containerizer process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50841/ --- Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and Rajat