Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-12 Thread Avinash sridharan
> On Aug. 11, 2016, 8:17 p.m., Jie Yu wrote: > > docs/cni.md, lines 241-243 > > > > > > This is inconsistent with the previous paragraph. > > > > ``` > > Whenever the `network/cni` isolator needs to atta

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-11 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/ --- (Updated Aug. 11, 2016, 10:58 p.m.) Review request for mesos, Jie Yu and Qian Z

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/#review145573 --- Patch looks great! Reviews applied: [50769, 50940, 50941] Passed

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/#review145553 --- docs/cni.md (lines 241 - 243)

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/ --- (Updated Aug. 10, 2016, 1:41 a.m.) Review request for mesos, Jie Yu and Qian Zh

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-09 Thread Avinash sridharan
> On Aug. 10, 2016, 1:26 a.m., Qian Zhang wrote: > > docs/cni.md, lines 221-222 > > > > > > I think it keeps an in-memory copy in > > `NetworkCniIsolatorProcess::NetworkConfigInfo::config`. NetworkCniIsolatorProces

Re: Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-09 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/#review145297 --- docs/cni.md (lines 221 - 222)

Review Request 50941: Added a section on "Adding/Modifying/Deleting CNI configuration".

2016-08-09 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50941/ --- Review request for mesos. Bugs: MESOS-5985 https://issues.apache.org/jira/b