Review Request 51068: Prevent memory leaks

2016-08-13 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/ --- Review request for mesos. Repository: mesos Description --- This should

Re: Review Request 51068: Prevent memory leaks

2016-08-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145696 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 51068: Prevent memory leaks

2016-08-13 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145706 --- Hi Aaron, Awesome, thanks for your contribution! Two quick sugges

Re: Review Request 51068: Prevent memory leaks

2016-08-14 Thread Aaron Wood
> On Aug. 13, 2016, 8:07 p.m., Neil Conway wrote: > > Hi Aaron, > > > > Awesome, thanks for your contribution! Two quick suggestions: > > > > (1) Is there a workload/tool that repros the memory leak? e.g., it would be > > good to be able to say that "when you do X (e.g., run unit test X) under

Re: Review Request 51068: Prevent memory leaks

2016-08-16 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review145930 --- Hey Aaron, I was not able to identify the leaks you were addressin

Re: Review Request 51068: Prevent memory leaks

2016-08-17 Thread Aaron Wood
> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > src/zookeeper/zookeeper.cpp, lines 196-220 > > > > > > Promise is now on the stack here, but the asynchronous callbacks > > (voidCompletion, stringCompletio

Re: Review Request 51068: Prevent memory leaks

2016-08-17 Thread Aaron Wood
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/ --- (Updated Aug. 17, 2016, 6:21 p.m.) Review request for mesos. Repository: meso

Re: Review Request 51068: Prevent memory leaks

2016-08-17 Thread Aaron Wood
> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > src/zookeeper/zookeeper.cpp, lines 196-220 > > > > > > Promise is now on the stack here, but the asynchronous callbacks > > (voidCompletion, stringCompletio

Re: Review Request 51068: Prevent memory leaks

2016-08-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51068/#review146037 --- Bad review! Reviews applied: [] Error: No reviewers specified. P

Re: Review Request 51068: Prevent memory leaks

2016-08-18 Thread Aaron Wood
> On Aug. 16, 2016, 11:35 p.m., Benjamin Mahler wrote: > > Hey Aaron, I was not able to identify the leaks you were addressing. Also > > there seems to be some object lifetime issues introduced with this patch. It looks like I was wrong about this, I had thought the copy constructor of tuple w