Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6096 h

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review147731 --- Patch looks great! Reviews applied: [51622, 51623] Passed comman

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review147883 --- src/cli/execute.cpp (lines 111 - 121)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 6, 2016, 6:24 p.m., Joseph Wu wrote: > > src/cli/execute.cpp, lines 111-121 > > > > > > There will be less code duplication if you made `--command` into an > > alias of `--commands`. You can parse a sing

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review148188 --- Fix it, then Ship it! src/cli/execute.cpp (lines 117 - 121)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > oops didnt mean to give a ship it :) - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review148188 -

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review148966 --- any update on this? - Vinod Kone On Sept. 3, 2016, 8:36 p.m., A

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 14, 2016, 8:55 p.m., Vinod Kone wrote: > > any update on this? Yeah...working on it..will post patch shortly. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#revi

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 16, 2016, 6:58 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For e

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149242 --- partial review. src/cli/execute.cpp (line 116)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On Sept. 16, 2016, 7:42 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, line 119 > > > > > > Instead of hand-coded JSON, this should match the TaskGroup proto. See > > `volumes` below for how to do it. Didn't qu

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149269 --- src/cli/execute.cpp (lines 309 - 313)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149308 --- Patch looks great! Reviews applied: [51623] Passed command: expo

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 17, 2016, 8:56 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149353 --- Bad patch! Reviews applied: [51623, 51991, 51990, 51978] Failed

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149352 --- src/cli/execute.cpp (lines 73 - 74)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On 九月 18, 2016, 1:33 a.m., Guangya Liu wrote: > > Can you please also append your file:///home/abhishek/taskgroup.txt to the `Testing Done` section? - Guangya --- This is an automatically generated e-mail. To reply, visit: https://re

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149356 --- src/cli/execute.cpp (line 270)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 18, 2016, 3:34 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149372 --- Patch looks great! Reviews applied: [51978, 51990, 51991, 51623]

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149375 --- src/cli/execute.cpp (line 457)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 18, 2016, 9:11 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149393 --- src/cli/execute.cpp (line 98)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149414 --- src/cli/execute.cpp (lines 100 - 101)

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149427 --- Patch looks great! Reviews applied: [51978, 51991, 51990, 51623]

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 19, 2016, 6:54 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149448 --- Bad patch! Reviews applied: [51978, 51991, 51990, 51623] Failed

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review149531 --- Ship it! LGTM module "taskGroup" flag name to "task_group" per

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/ --- (Updated Sept. 19, 2016, 7:45 p.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 51623: Updated mesos-execute to support task groups.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review150079 --- src/cli/execute.cpp (line 270)

Re: Review Request 51623: Updated mesos-execute to support task groups.

> On 九月 22, 2016, 10:02 p.m., Zhitao Li wrote: > > src/cli/execute.cpp, line 270 > > > > > > Does this work when `--task_group` is not specified? It seems to cause > > segfault. Can you show more detail for your co