Review Request 51715: Added a parallel gtest runner.

2016-09-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- Review request for mesos, Kevin Klues, Till Toenshoff, and Vinod Kone. Reposito

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151984 --- Fix it, then Ship it! Looks very good guys - thanks Kevin for r

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-11 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 11, 2016, 10:18 a.m.) Review request for mesos, Kevin Klues and T

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-11 Thread Benjamin Bannier
> On Oct. 10, 2016, 5:22 p.m., Till Toenshoff wrote: > > Looks very good guys - thanks Kevin for reviewing and Benjamin for actually > > making it happen - we all will love this stuff! :) > > > > I specifically like the idea of not finishing right here but keeping an eye > > on the results / d

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-12 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review152322 --- Ship it! Ship It! - Kevin Klues On Oct. 11, 2016, 8:18 a.m.,

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 12, 2016, 5:28 p.m.) Review request for mesos, Kevin Klues and Ti

Re: Review Request 51715: Added a parallel gtest runner.

2016-09-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Sept. 8, 2016, 1:15 p.m.) Review request for mesos, Kevin Klues, Till

Re: Review Request 51715: Added a parallel gtest runner.

2016-09-14 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review149005 --- support/mesos-gtest-runner.py (line 13)

Re: Review Request 51715: Added a parallel gtest runner.

2016-09-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Sept. 19, 2016, 4:35 p.m.) Review request for mesos, Kevin Klues and T

Re: Review Request 51715: Added a parallel gtest runner.

2016-09-19 Thread Benjamin Bannier
> On Sept. 15, 2016, 3:16 a.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, lines 36-37 > > > > > > What is a shard in this context? I introduce this term in the script docstring now. > On Sept. 15, 2016,

Re: Review Request 51715: Added a parallel gtest runner.

2016-09-21 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review149849 --- Looking good! Just a few more comments. support/mesos-gtest-runn

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 1, 2016, 12:54 p.m.) Review request for mesos, Kevin Klues and Ti

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151118 --- Fix it, then Ship it! The code itself looks great! Just a few s

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 1, 2016, 9:02 p.m.) Review request for mesos, Kevin Klues and Til

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Oct. 1, 2016, 7:43 p.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, lines 5-12 > > > > > > I would consider rewording this slightly, as it's not exactly clear to > > me what the difference between a Go

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/ --- (Updated Oct. 1, 2016, 9:06 p.m.) Review request for mesos, Kevin Klues and Til

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151122 --- As a side note (I'm fine with shipping it as is for now), I'm wond

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Oct. 1, 2016, 11:10 p.m., Kevin Klues wrote: > > As a side note (I'm fine with shipping it as is for now), I'm wondering if > > we can't improve the output we see before / during / after the tests run. > > Right now, if I run `mesos-tests` I don't start to see any output for at > > least

Re: Review Request 51715: Added a parallel gtest runner.

2016-10-01 Thread Benjamin Bannier
> On Sept. 21, 2016, 8:53 p.m., Kevin Klues wrote: > > support/mesos-gtest-runner.py, line 214 > > > > > > Can you add a quick comment about how this filter is working? It's not > > obvious at first glance what it's