Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 29, 2016, 4:21 a.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 28, 2016, 7:04 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 27, 2016, 3:35 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-27 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review150568 --- Ship it! Ship It! - Gastón Kleiman On Sept. 23, 2016, 3:28

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-25 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review150371 --- Ship it! LGTM! Much appreciated. - Jiang Yan Xu On Sept.

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-22 Thread Jiang Yan Xu
> On Sept. 12, 2016, 10:57 a.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-22 Thread haosdent huang
> On Sept. 12, 2016, 5:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 21, 2016, 6:21 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 21, 2016, 6:17 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 13, 2016, 1:47 a.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Jiang Yan Xu
> On Sept. 12, 2016, 10:57 a.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 6:30 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
> On Sept. 12, 2016, 5:57 p.m., Jiang Yan Xu wrote: > > include/mesos/mesos.proto, line 372 > > > > > > In genenal I think we should state "Feature X will be deprecated in > > version Y in favor of feature Z" to

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? > > haosdent huang

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148536 --- include/mesos/mesos.proto (line 372)

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Silas Snider
> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? > > haosdent huang

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
> On Sept. 12, 2016, 5:23 p.m., Silas Snider wrote: > > include/mesos/mesos.proto, line 374 > > > > > > Why is this being deprecated when the comment above mentions needing to > > support it? @swsnider, we may not

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Silas Snider
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148521 --- include/mesos/mesos.proto (line 374)

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148488 --- Ship it! Ship It! - Alexander Rukletsov On Sept. 12, 2016,

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 2 p.m.) Review request for mesos, Alexander

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/#review148484 --- include/mesos/mesos.proto (lines 358 - 359)

Re: Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- (Updated Sept. 12, 2016, 1:17 p.m.) Review request for mesos, Alexander

Review Request 51803: Ensured `HealthCheck::HTTPCheckInfo` compatible with the old one.

2016-09-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51803/ --- Review request for mesos, Alexander Rukletsov, Joseph Wu, Silas Snider, and