Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-06-01 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated June 1, 2017, 7:16 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-06-01 Thread Anindya Sinha
> On June 1, 2017, 12:42 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp > > Lines 113 (patched) > > > > > > Sorry I know you had https://reviews.apache.org/r/52002 which was > > originally

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-05-31 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review176411 --- Sorry this patch had to go through this long delay. We couldn't re

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-05-31 Thread Jiang Yan Xu
> On Dec. 15, 2016, 11:58 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp > > Lines 165-169 (original), 288-305 (patched) > > > > > > Here what I found to be a bit awkward: > > > > W

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-05-24 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated May 24, 2017, 7:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2017-03-01 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review167528 --- Closing this review due to inactivity. Please see our [guidelines

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Dec. 18, 2016, 8:38 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-18 Thread Anindya Sinha
> On Dec. 16, 2016, 7:58 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp, lines 327-344 > > > > > > Here what I found to be a bit awkward: > > > > We already know here that we want t

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-16 Thread Jiang Yan Xu
> On Dec. 15, 2016, 11:58 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/containerizer.cpp, line 142 > > > > > > Remove the `.`. Haha this formatting look odd. I meant s/path./path/ - Jiang Yan -

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review159311 --- LGTM! Just some minor comments. src/common/resources.cpp (lines

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-09 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Dec. 10, 2016, 1:19 a.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-12-09 Thread Anindya Sinha
> On Nov. 30, 2016, 8:51 a.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, line 1927 > > > > > > No empty lines here. Ok. Although I do see patterns without { } and / or with empty lines. > On Nov. 30, 201

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-11-30 Thread Jiang Yan Xu
> On Sept. 28, 2016, 3:37 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-618 > > > > > > No need for the helpers. Just the following is sufficient. > > > > ``` > > Resource resource; >

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-11-30 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review157057 --- include/mesos/resources.hpp (lines 138 - 148)

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Oct. 25, 2016, 6:19 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-25 Thread Anindya Sinha
> On Sept. 28, 2016, 10:37 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-618 > > > > > > No need for the helpers. Just the following is sufficient. > > > > ``` > > Resource resource;

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-05 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Oct. 6, 2016, 2 a.m.) Review request for mesos and Jiang Yan Xu. Cha

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-05 Thread Jiang Yan Xu
> On Sept. 28, 2016, 3:37 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-618 > > > > > > No need for the helpers. Just the following is sufficient. > > > > ``` > > Resource resource; >

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-04 Thread Guangya Liu
> On 九月 28, 2016, 10:37 p.m., Jiang Yan Xu wrote: > > src/common/resources.cpp, lines 587-618 > > > > > > No need for the helpers. Just the following is sufficient. > > > > ``` > > Resource resource; > >

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-10-03 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Oct. 3, 2016, 11:46 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-09-28 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/#review150615 --- Partial review. Will continue after discussion. src/common/resou

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-09-28 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 28, 2016, 7:25 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-09-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 26, 2016, 8:59 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 51879: Autodetect value of resource when not specified in static resources.

2016-09-25 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51879/ --- (Updated Sept. 26, 2016, 6:51 a.m.) Review request for mesos and Jiang Yan Xu.