Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jiang Yan Xu
> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jiang Yan Xu
> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jiang Yan Xu
> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jiang Yan Xu
> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jiang Yan Xu
> On Oct. 19, 2016, 5:49 p.m., Jie Yu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 608 > > > > > > THis test will certainly break if nobody does not have access to my > > home dir where I

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review153334 --- src/tests/containerizer/mesos_containerizer_tests.cpp (line 608)

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152772 --- Patch looks great! Reviews applied: [52828, 52058] Passed comman

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-14 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 14, 2016, 6:14 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152600 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp (lin

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review152581 --- Patch looks great! Reviews applied: [52828, 52058] Passed comman

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 13, 2016, 2:33 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-13 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 13, 2016, 2:30 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-12 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 12, 2016, 9:38 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-06 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 6, 2016, 6:28 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-05 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 5, 2016, 5:44 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-05 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 5, 2016, 5:40 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-10-04 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Oct. 4, 2016, 5:54 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-29 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review150823 --- src/slave/containerizer/fetcher.cpp (lines 755 - 756)

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-28 Thread Jiang Yan Xu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-28 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 28, 2016, 5:17 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-28 Thread Megha Sharma
> On Sept. 26, 2016, 11:41 p.m., Anindya Sinha wrote: > > src/slave/containerizer/fetcher.cpp, line 784 > > > > > > I think this should be more like: > > ``` > > if (chownOut.isError() || chownErr.isError())

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-28 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 28, 2016, 5:10 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-26 Thread Joseph Wu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review150485 --- src/slave/containerizer/fetcher.cpp (line 765)

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-26 Thread Jiang Yan Xu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-26 Thread Joseph Wu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-26 Thread Jiang Yan Xu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/#review149795 --- Patch looks great! Reviews applied: [52058] Passed command: expo

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-20 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 20, 2016, 11:32 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-19 Thread Megha Sharma
> On Sept. 19, 2016, 8:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-19 Thread Joseph Wu
> On Sept. 19, 2016, 1:35 p.m., Joseph Wu wrote: > > src/slave/containerizer/fetcher.cpp, lines 773-775 > > > > > > (You'll want to update this comment.) > > > > There isn't always a stdout/stderr file in th

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-19 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 19, 2016, 11:08 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-19 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- (Updated Sept. 19, 2016, 11:04 p.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52058: Fixed fetcher to not call chown on sandbox again.

2016-09-19 Thread Megha Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52058/ --- Review request for mesos. Bugs: MESOS-5218 https://issues.apache.org/jira/b