Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 11:22 p.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 11:12 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/paths.cpp, lines 146-149 > > > > > > termination could be None, right? Calling error will an assertion > > failure. Yes, of course. S

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151103 --- - Kevin Klues On Sept. 30, 2016, 11:08 p.m., Kevin Klues wrote:

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151102 --- src/slave/containerizer/mesos/paths.cpp (lines 146 - 149)

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 9:52 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 711-713 > > > > > > Can you introduce a helper in paths.hpp|cpp: > > > > ``` > > paths::getContain

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 11:08 p.m.) Review request for mesos, Gilbert Song, Ji

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

> On Sept. 30, 2016, 9:52 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 711-713 > > > > > > Can you introduce a helper in paths.hpp|cpp: > > > > ``` > > paths::getContain

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151092 --- Fix it, then Ship it! src/slave/containerizer/mesos/containeri

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 9:27 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151090 --- src/tests/containerizer/nested_container_tests.cpp (line 117)

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/#review151084 --- Fix it, then Ship it! LGTM. src/slave/containerizer/mesos/con

Re: Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- (Updated Sept. 30, 2016, 8:57 p.m.) Review request for mesos, Gilbert Song, Jie

Review Request 52446: Updated 'destroy()' to checkpoint termination state of nested container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52446/ --- Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone. Repository: mes