Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-14 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152723 --- Ship it! Ship It! - Vinod Kone On Oct. 13, 2016, 6:36 a.m.,

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 13, 2016, 6:36 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152410 --- include/mesos/mesos.proto

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152404 --- src/master/validation.cpp (line 1115)

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 5:18 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 5:17 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
> On Oct. 12, 2016, 12:08 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 3529-3555 > > > > > > I think we might want to mutate TaskInfo here so that authorization can > > use that information. > > >

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 10:02 a.m.) Review request for mesos, Anand Mazumdar an

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 12, 2016, 9:29 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review152218 --- src/master/master.cpp (lines 3529 - 3555)

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-10 Thread haosdent huang
> On Oct. 10, 2016, 6:54 p.m., Vinod Kone wrote: > > I think it's probably worth to just mutate TaskInfo like you did in the > > very first diff rather than doing all these changes. They are bit messy and > > incomplete. > > haosdent huang wrote: > Let's use mutating way. I drop following

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 11, 2016, 6:06 a.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review151823 --- ping, when do you plan to update this? we need this sooner than la

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-04 Thread Vinod Kone
> On Oct. 3, 2016, 10:28 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4339 > > > > > > Mutating TaskInfo should be avoided as much as possible. > > > > I don't follow why we need this. > >

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-04 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 4, 2016, 5:59 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-03 Thread haosdent huang
> On Oct. 3, 2016, 10:28 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4339 > > > > > > Mutating TaskInfo should be avoided as much as possible. > > > > I don't follow why we need this. > >

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/#review151238 --- src/master/master.cpp (line 4339)

Re: Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- (Updated Oct. 3, 2016, 2:56 a.m.) Review request for mesos, Anand Mazumdar and

Review Request 52470: Filled missing executor info in tasks when `LAUNCH_GROUP`.

2016-10-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52470/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Bugs: MESOS-6283 h