Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-07 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6329 https://issues.ap

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/#review151924 --- Patch looks great! Reviews applied: [50235, 50416, 50417, 50418,

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-17 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/#review152999 --- Fix it, then Ship it! src/tests/master_authorization_tests.cpp

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-17 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- (Updated Oct. 18, 2016, 1:05 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-17 Thread Neil Conway
> On Oct. 18, 2016, 12:35 a.m., Vinod Kone wrote: > > src/tests/master_authorization_tests.cpp, line 783 > > > > > > This test looks identical to SlaveRemoved test. Please kill this in a > > different review. Done,

Re: Review Request 52659: Changed master to send TASK_DROPPED for task launch errors.

2016-10-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52659/ --- (Updated Oct. 18, 2016, 9:09 p.m.) Review request for mesos and Vinod Kone. C