Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 1:53 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153998 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 27, 2016, 12

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 12:14 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 12:02 p.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52786: Add the health check test helper.

2016-10-27 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 27, 2016, 11:54 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52786: Add the health check test helper.

2016-10-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153871 --- src/Makefile.am (line 1006)

Re: Review Request 52786: Add the health check test helper.

2016-10-21 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 21, 2016, 11:12 a.m.) Review request for mesos, Alexander Ruklets

Re: Review Request 52786: Add the health check test helper.

2016-10-21 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review153520 --- I applied this patch on top of master and the tests don't compile

Re: Review Request 52786: Add the health check test helper.

2016-10-17 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- (Updated Oct. 17, 2016, 2:51 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 52786: Add the health check test helper.

2016-10-17 Thread haosdent huang
> On Oct. 17, 2016, 12:34 p.m., Gastón Kleiman wrote: > > src/tests/containerizer/health_check_test_helper.cpp, line 66 > > > > > > Yhis method is so short, that I don't think we need this comment. > > > > Bu

Re: Review Request 52786: Add the health check test helper.

2016-10-17 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/#review152863 --- Fix it, then Ship it! src/tests/containerizer/health_check_tes

Review Request 52786: Add the health check test helper.

2016-10-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52786/ --- Review request for mesos, Alexander Rukletsov and Gastón Kleiman. Bugs: MESOS-6